fix: lowercase metamask_accountsChanged address casing to match eth_accounts
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiexi
changed the title
metamask_accountsChanged address casing to match eth_accounts
jiexi
commented
Nov 17, 2025
|
|
||
| - Fix connections made from within the MetaMask Mobile In-App Browser ([#21](https://github.com/MetaMask/connect-monorepo/pull/21)) | ||
| - Bump `@metamask/multichain-api-client` to prevent JSON RPC request ID conflicts across disconnect/reconnect cycles ([#38](https://github.com/MetaMask/connect-monorepo/pull/38)) | ||
| - Lowercase cached account address values from `metamask_accountsChanged` to align with `eth_accounts` ([#40](https://github.com/MetaMask/connect-monorepo/pull/40)) |
Contributor
Author
There was a problem hiding this comment.
this doesn't really matter unless you're using the connect-evm package though
Member
There was a problem hiding this comment.
Should we specify that this only applies to legacy connector package then ?
ffmcgee725
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
BackgroundBridge returns checksummed addresses in the
metamask_accountsChangedevent but lowercase in theeth_accountsresponses. This PR "fixes" that by lowercasing the incomingmetamask_accoutnsChangedaddresses. This also aligns with how addresses are presented to the dapp in the injected EIP-1193 providerReferences
Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-834
Checklist